🌱 Refine v1beta2 ScalingUp conditions #11432
Merged
+201
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/provider/core
k8s-ci-robot
added
the
size/L
sbueringer
reviewed
Nov 18, 2024
internal/controllers/machineset/machineset_controller_status.go
Outdated
Show resolved
Hide resolved
fabriziopandini
force-pushed
the
refine-v1beta2-scalingup-conditions
branch
from
ed8a31d
to
7aa7b8d
Compare
sbueringer
reviewed
Nov 18, 2024
fabriziopandini
force-pushed
the
refine-v1beta2-scalingup-conditions
branch
from
7aa7b8d
to
f262b53
Compare
sbueringer
reviewed
Nov 18, 2024
fabriziopandini
force-pushed
the
refine-v1beta2-scalingup-conditions
branch
from
f262b53
to
074211a
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 1408822e9a45e7f9e3faf962c44fb1306b79e47a
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Ensure scaling up conditions shows preflight errors using lists
/area provider/core
Part of #11105