✨ Add machine UpToDate condition to MachineSet #11393
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
area/machineset
k8s-ci-robot
added
the
size/L
59 tasks
sbueringer
reviewed
Nov 8, 2024
k8s-ci-robot
added
needs-rebase
fabriziopandini
force-pushed
the
add-machine-upToDate-condition-to-MachineSet
branch
from
02973bf
to
24bc10b
Compare
k8s-ci-robot
removed
the
needs-rebase
sbueringer
reviewed
Nov 11, 2024
|
Flake independent of this PR (https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/kubernetes-sigs_cluster-api/11393/pull-cluster-api-test-main/1855952753193390080) |
|
Thx, very nice !! :) /lgtm /hold |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 038cb088c9a7bf095e07267d4b09f12c9f458862
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
fabriziopandini
force-pushed
the
add-machine-upToDate-condition-to-MachineSet
branch
from
7891fad
to
769af58
Compare
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
fabriziopandini
deleted the
add-machine-upToDate-condition-to-MachineSet
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Rif #11105
/area machineset