🌱 Add feature gate to consider VolumeAttachments when waiting for volume detach #11386
Conversation
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
size/M
sbueringer
added
the
area/machine
volume detach Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-add-fg-volume-detach-attachments
branch
from
f216c60
to
938a34b
Compare
|
/test pull-cluster-api-e2e-main |
|
it feels odd we enable a feature gate to preserve a previous behaviour. This sounds like one action express slightly different semantic intent from the other one and this should be a configuration knob that might be enable/disable only when properly understanding the implications. |
|
The idea is basically to give folks an option to opt-out in case we are missing something. In general we think it is the right thing to do to look both at Node.status and VolumeAttachments (and that should be the only behavior eventually) It's hard to foresee what situations folks might run into with CSI. So we wanted to give folks an alternative to having to set WaitForVolumeDetachTimeout. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: cfbcc73f8ff42b8ba561fdfff5dc8076043d3920
|
|
/test pull-cluster-api-e2e-main Test failure seems very unrelated |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Since #11246 we are now also considering VolumeAttachments. Goal of this feature gate is to allow folks to opt-out in case unexpected problems occur.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11240