-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Fixing TestClusterResourceSetReconciler flaky test #11379
🌱 Fixing TestClusterResourceSetReconciler flaky test #11379
Conversation
Signed-off-by: Muhammad Adil Ghaffar <[email protected]>
@adilGhaffarDev: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
cc @cahillsf |
/area testing |
Thank you very much!! /lgtm |
LGTM label has been added. Git tree hash: 61aae331b750fee08ec22f59ef27f5f0dad5f2b7
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What this PR does / why we need it:
This PR is changing Delete to CleanupAndWait so we can make sure that
fakeService
is deleted before we start creatingkubernetesAPIServerService
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):This PR is fixing this flake:
https://storage.googleapis.com/k8s-triage/index.html?job=.*-cluster-api-.*&xjob=.*-provider-.*%7C.*-operator-.*#1dd40f6a601b864b9511
Failure is:
Service "kubernetes" is invalid: spec.clusterIPs: Invalid value: []string{"10.0.0.1"}: failed to allocate IP 10.0.0.1: provided IP is already allocated
Can be seen here: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-cluster-api-test-mink8s-main/1853481305933615104
/area test