Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Fixing TestClusterResourceSetReconciler flaky test #11379

Conversation

adilGhaffarDev
Copy link
Contributor

What this PR does / why we need it:
This PR is changing Delete to CleanupAndWait so we can make sure that fakeService is deleted before we start creating kubernetesAPIServerService

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
This PR is fixing this flake:

https://storage.googleapis.com/k8s-triage/index.html?job=.*-cluster-api-.*&xjob=.*-provider-.*%7C.*-operator-.*#1dd40f6a601b864b9511

Failure is:
Service "kubernetes" is invalid: spec.clusterIPs: Invalid value: []string{"10.0.0.1"}: failed to allocate IP 10.0.0.1: provided IP is already allocated
Can be seen here: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-cluster-api-test-mink8s-main/1853481305933615104

/area test

@k8s-ci-robot
Copy link
Contributor

@adilGhaffarDev: The label(s) area/test cannot be applied, because the repository doesn't have them.

In response to this:

What this PR does / why we need it:
This PR is changing Delete to CleanupAndWait so we can make sure that fakeService is deleted before we start creating kubernetesAPIServerService

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
This PR is fixing this flake:

https://storage.googleapis.com/k8s-triage/index.html?job=.*-cluster-api-.*&xjob=.*-provider-.*%7C.*-operator-.*#1dd40f6a601b864b9511

Failure is:
Service "kubernetes" is invalid: spec.clusterIPs: Invalid value: []string{"10.0.0.1"}: failed to allocate IP 10.0.0.1: provided IP is already allocated
Can be seen here: https://prow.k8s.io/view/gs/kubernetes-ci-logs/logs/periodic-cluster-api-test-mink8s-main/1853481305933615104

/area test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 5, 2024
@adilGhaffarDev
Copy link
Contributor Author

cc @cahillsf

@adilGhaffarDev adilGhaffarDev changed the title Fixing TestClusterResourceSetReconciler flaky test 🌱 Fixing TestClusterResourceSetReconciler flaky test Nov 5, 2024
@adilGhaffarDev
Copy link
Contributor Author

/area testing

@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing and removed do-not-merge/needs-area PR is missing an area label labels Nov 5, 2024
@sbueringer
Copy link
Member

Thank you very much!!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 61aae331b750fee08ec22f59ef27f5f0dad5f2b7

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 5, 2024
@k8s-ci-robot k8s-ci-robot merged commit 8fe14d4 into kubernetes-sigs:main Nov 5, 2024
25 of 26 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.9 milestone Nov 5, 2024
@Sunnatillo Sunnatillo deleted the fix-TestClusterResourceSetReconciler/adil branch November 5, 2024 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants