🌱 KCP: Skip validation if CoreDNS migration library supports an upgrade if the library is not used #11319
Conversation
k8s-ci-robot
added
the
cncf-cla: yes
|
This PR is currently missing an area label, which is used to identify the modified component when generating release notes. Area labels can be added by org members by writing Please see the labels list for possible areas. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/S
sbueringer
added
area/provider/control-plane-kubeadm
|
/assign @chrischdi @fabriziopandini @vincepri |
|
/cherry-pick release-1.8 |
|
@sbueringer: once the present PR merges, I will cherry-pick it on top of release-1.8 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
k8s-ci-robot
added
the
size/S
|
/test pull-cluster-api-e2e-main |
controlplane/kubeadm/internal/webhooks/kubeadm_control_plane.go
Outdated
Show resolved
Hide resolved
skip CoreDNS is set Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-skip-kcp-val
branch
from
fa041ed
to
7e13754
Compare
k8s-ci-robot
added
the
cncf-cla: yes
|
/test pull-cluster-api-e2e-main |
k8s-ci-robot
added
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: d4d84816f838f173899cd510d50e3c76e7d5f9cc
|
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@sbueringer: new pull request created: #11325 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
It doesn't make sense to check if the migratoin library supports an upgrade if the code doing the CoreDNS upgrade is skipped. So let's get rid of it
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #