🌱 Check for panics during test runs in envtest #11279
Conversation
Signed-off-by: Stefan Büringer [email protected]
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
|
/assign @fabriziopandini @chrischdi @vincepri |
|
@chrischdi @fabriziopandini Once this is merged, I think it would be a good idea to rebase your current PRs on top of it. Should make it a lot easier to find panics (e2e tests are checking the same, but it's more annoying to find the panics there + our unit test coverage is higher) |
|
Super awesome addition! /lgtm /hold To give others some time. |
k8s-ci-robot
added
do-not-merge/hold
|
LGTM label has been added. Git tree hash: 67dddf53788800c291f2c4833ea60b0c1162f561
|
k8s-ci-robot
added
the
approved
|
/test pull-cluster-api-e2e-main |
|
Yes! |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi, fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Part of #11272