Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📖 Clarify MinReadySeconds transition in the v1Beta2 API #11251

Merged
merged 1 commit into from
Oct 6, 2024
Merged

📖 Clarify MinReadySeconds transition in the v1Beta2 API #11251

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions docs/proposals/20240916-improve-status-in-CAPI-resources.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,14 +420,17 @@ type MachineReadinessGate struct {

| v1beta1 (tentative Dec 2024) | v1Beta2 (tentative Apr 2025) | v1beta2 after v1beta1 removal (tentative Apr 2026) |
|------------------------------|------------------------------|----------------------------------------------------|
| `MinReadySeconds` (new) | `MinReadySeconds` | `MinReadySeconds` |
| | `MinReadySeconds` (renamed) | `MinReadySeconds` |
| `ReadinessGates` (new) | `ReadinessGates` | `ReadinessGates` |
| other fields... | other fields... | other fields... |

Notes:
- Both `MinReadySeconds` and `ReadinessGates` should be treated as other in-place propagated fields (changing them should not trigger rollouts).
- As of today v1beta1 MachineDeployments, MachineSets, MachinePools already have a `spec.MinReadySeconds` field.
In v1beta2 those field are going to be migrated to MachineDeployments, MachineSets, MachinePools `spec.template.spec.MinReadySeconds` field, which is
the `MinReadySeconds` field added in the first line of the table above.
- Similarly to Pod's `ReadinessGates`, also Machine's `ReadinessGates` accept only conditions with positive polarity;
The Cluster API project might revisit this in the future to stay aligned with Kubernetes or if there are use cases justifying this change.
- Both `MinReadySeconds` and `ReadinessGates` should be treated as other in-place propagated fields (changing them should not trigger rollouts).

#### Machine Print columns

Expand Down
Loading