🌱 Enable race detector for main module unit tests

[sbueringer]

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Took the part for the unit tests of the main module from #10899.
I want to get the race detector for this part of our code base ASAP.

This PR:

• enables the race detector for make test & make junit-test
• make junit-test uses -json, because of that I had to make sure a proper logger is used in envtest unit tests, otherwise we hit a race condition when writing/reading os.Stderr
• Fuzz tests time out after 10m when run with the race detector, because of that all test files with fuzz tests have been flagged with go build !race. Additional test executions have been added to make test and make test-junit to ensure the tests in these files are still executed (the !race tag means that these files are entirely ignored when running tests with -race)
• The race detector slows down the test job. It now takes around 18m instead of 10m. But I think it's worth it. Also we usually have to wait for the e2e-blocking test anyway and that one takes ~17m.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

[sbueringer]

/hold

Just testing at the moment

[sbueringer]

/test pull-cluster-api-test-main

[fabriziopandini]

overall sgmt, just few nits
ping me when it is ready for a final pass

[sbueringer]

@fabriziopandini Thx, fixed!

/hold cancel

[sbueringer]

/test pull-cluster-api-e2e-main

[sbueringer]

/assign @fabriziopandini @chrischdi

[chrischdi]

/approve

[sbueringer]

Checked, the usual MP flake ..

/override pull-cluster-api-e2e-main

[k8s-ci-robot]

@sbueringer: Overrode contexts on behalf of sbueringer: pull-cluster-api-e2e-main

In response to this:

Checked, the usual MP flake ..

/override pull-cluster-api-e2e-main

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[fabriziopandini]

Nice
/lgtm
/approve

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: c0fb8f027d1adf1db4f5223c14ffe4febb97f45e

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi, fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [chrischdi,fabriziopandini]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[sbueringer]

@kubernetes-sigs/cluster-api-release-team I ran this a few times, and I think I fixed all the race conditions we had. But please let me know if the periodic test job gets flaky with issues reported by the race detector. Happy to take a look / help to fix them! :)