✨ clusterctl: Allow user to suppress API warnings #11149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
do-not-merge/needs-area
|
/cc @sbueringer |
dlipovetsky
force-pushed
the
option-suppress-api-warnings
branch
from
664b3f2
to
142cbb2
Compare
|
I also have a commit that uses this to hide API warnings in the |
|
/area clusterctl |
k8s-ci-robot
added
area/clusterctl
|
Thx! /lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: f96dd35df5dc79f2bcc688d3e838b5c1b9f7fa59
|
Maybe we should only hide specific warnings, but no strong opinion (+ let's discuss this on the next PR) |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sbueringer The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Allows the clusterctl user to configure the API client warning handler.
The warning handler is configured by the Proxy. If a user only wants to configure the warning handler, we should not require them to implement their own Proxy. This PR, therefore, exports our Proxy constructor, and adds an option that allows the user to construct a Proxy with their own warning handler.
The PR does not change the existing warning handling behavior. As before, the default warning handler is provided by the controller-runtime client. Its default warning warning handler has not changed.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #10932