Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.7] 🐛 Drop caBundle from CRDs #10978

Merged
merged 1 commit into from
Aug 1, 2024
Merged

[release-1.7] 🐛 Drop caBundle from CRDs #10978

merged 1 commit into from
Aug 1, 2024

Conversation

sbueringer
Copy link
Member

Signed-off-by: Stefan Büringer [email protected]

What this PR does / why we need it:
Manual cherry-pick of #10972

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

@sbueringer
Drop caBundle from CRDs
df8b107 
Signed-off-by: Stefan Büringer [email protected]
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Aug 1, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 1, 2024
@sbueringer sbueringer added the area/api Issues or PRs related to the APIs label Aug 1, 2024
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-area PR is missing an area label label Aug 1, 2024
@sbueringer
Copy link
Member Author

/test ?

@k8s-ci-robot
Copy link
Contributor

@sbueringer: The following commands are available to trigger required jobs:

  • /test pull-cluster-api-build-release-1-7
  • /test pull-cluster-api-e2e-blocking-release-1-7
  • /test pull-cluster-api-e2e-conformance-ci-latest-release-1-7
  • /test pull-cluster-api-e2e-conformance-release-1-7
  • /test pull-cluster-api-e2e-mink8s-release-1-7
  • /test pull-cluster-api-e2e-release-1-7
  • /test pull-cluster-api-e2e-upgrade-1-29-1-30-release-1-7
  • /test pull-cluster-api-test-mink8s-release-1-7
  • /test pull-cluster-api-test-release-1-7
  • /test pull-cluster-api-verify-release-1-7

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-apidiff-release-1-7

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-apidiff-release-1-7
  • pull-cluster-api-build-release-1-7
  • pull-cluster-api-e2e-blocking-release-1-7
  • pull-cluster-api-test-release-1-7
  • pull-cluster-api-verify-release-1-7

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@sbueringer
Copy link
Member Author

/test pull-cluster-api-e2e-conformance-ci-latest-release-1-7
/test pull-cluster-api-e2e-conformance-release-1-7
/test pull-cluster-api-e2e-mink8s-release-1-7
/test pull-cluster-api-e2e-release-1-7
/test pull-cluster-api-e2e-upgrade-1-29-1-30-release-1-7

chrischdi
chrischdi reviewed Aug 1, 2024
View reviewed changes
Copy link
Member

@chrischdi chrischdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 1, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1a93d88f48df3c6df5fa73ebf067fc58374476e4

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 42491ab into kubernetes-sigs:release-1.7 Aug 1, 2024
28 checks passed
@sbueringer sbueringer deleted the pr-drop-ca-bundle-1.7 branch August 1, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chrischdi chrischdi chrischdi left review comments

@g-gaston g-gaston Awaiting requested review from g-gaston

Assignees

@chrischdi chrischdi

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/api Issues or PRs related to the APIs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
3 participants
@sbueringer @k8s-ci-robot @chrischdi