Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RBAC rules for infrastructure and bootstrap resources #1095

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

vincepri
Copy link
Member

@vincepri vincepri commented Jul 1, 2019

Signed-off-by: Vince Prignano [email protected]

What this PR does / why we need it:
This PR adds RBAC rules for the Cluster API manager to access and have permissions on all resources under infrastructure.cluster.sigs.k8s.io and boostrap.cluster.sigs.k8s.io.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Related to #1036

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:


@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2019
@k8s-ci-robot k8s-ci-robot requested review from detiber and justinsb July 1, 2019 17:56
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 1, 2019
@vincepri
Copy link
Member Author

vincepri commented Jul 1, 2019

/assign @ncdc @detiber

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2019
@detiber
Copy link
Member

detiber commented Jul 1, 2019

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 1, 2019
@vincepri
Copy link
Member Author

vincepri commented Jul 1, 2019

@detiber ptal :)

@ncdc
Copy link
Contributor

ncdc commented Jul 1, 2019

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2019
@ncdc
Copy link
Contributor

ncdc commented Jul 1, 2019

Are you thinking all bootstrap & infra providers will share the same API groups?

@vincepri
Copy link
Member Author

vincepri commented Jul 1, 2019

I think so? If they don't that's also fine, but they will need to add RBAC permissions to the Cluster API manager

@ncdc
Copy link
Contributor

ncdc commented Jul 1, 2019

If they don't that's also fine, but they will need to add RBAC permissions to the Cluster API manager

Right. Let's make sure we document this somewhere. Is there a good place now?

@detiber
Copy link
Member

detiber commented Jul 1, 2019

I believe the assumption should be fine for kubernetes-sigs hosted projects. For externally hosted projects we'll likely need to document the RBAC requirements.

@ncdc
Copy link
Contributor

ncdc commented Jul 1, 2019

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 1, 2019
@k8s-ci-robot k8s-ci-robot merged commit 6c10af9 into kubernetes-sigs:master Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants