-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add RBAC rules for infrastructure and bootstrap resources #1095
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vincepri The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: Vince Prignano <[email protected]>
/lgtm |
@detiber ptal :) |
/hold |
Are you thinking all bootstrap & infra providers will share the same API groups? |
I think so? If they don't that's also fine, but they will need to add RBAC permissions to the Cluster API manager |
Right. Let's make sure we document this somewhere. Is there a good place now? |
I believe the assumption should be fine for kubernetes-sigs hosted projects. For externally hosted projects we'll likely need to document the RBAC requirements. |
/hold cancel |
Signed-off-by: Vince Prignano [email protected]
What this PR does / why we need it:
This PR adds RBAC rules for the Cluster API manager to access and have permissions on all resources under
infrastructure.cluster.sigs.k8s.io
andboostrap.cluster.sigs.k8s.io
.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Related to #1036
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: