Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 export method and types for ClusterUpgradeWithRuntimeSDK #10788

Merged

Conversation

chrischdi
Copy link
Member

What this PR does / why we need it:

Exports the method and types to run ClusterUpgradeWithRuntimeSDK in provider e2e tests.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

/area testing

@k8s-ci-robot k8s-ci-robot added the area/testing Issues or PRs related to testing label Jun 21, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 21, 2024
@chrischdi
Copy link
Member Author

/assign sbueringer fabriziopandini

@chrischdi chrischdi force-pushed the pr-make-upgrade-runtime-sdk-public branch from 95097fa to 186a0a1 Compare June 24, 2024 10:24
@chrischdi
Copy link
Member Author

/retest

unrelated flake

@sbueringer
Copy link
Member

Thank you!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 47924ea5750499ae03985e85bb606c9afbe1c43f

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sbueringer

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2024
@k8s-ci-robot k8s-ci-robot merged commit b32476d into kubernetes-sigs:main Jun 25, 2024
20 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.8 milestone Jun 25, 2024
@sbueringer sbueringer changed the title 🌱 test: export method and types for ClusterUpgradeWithRuntimeSDK 🌱 export method and types for ClusterUpgradeWithRuntimeSDK Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/testing Issues or PRs related to testing cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants