Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.1 backports for noderef #1069

Merged
merged 25 commits into from
Jun 25, 2019
Merged

0.1 backports for noderef #1069

merged 25 commits into from
Jun 25, 2019

Conversation

ncdc
Copy link
Contributor

@ncdc ncdc commented Jun 25, 2019

What this PR does / why we need it:
Backports the following PRs from master to release-0.1:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

vincepri and others added 24 commits June 25, 2019 11:03
@vincepri @ncdc
Remove duplicate checks for deletionTimestamp (kubernetes-sigs#987)
f52769d 
Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit aacb0c6)
@vincepri @ncdc
Rename pkg/controller/controller (kubernetes-sigs#998)
89c59ff 
Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit eafafe8)
@vincepri @ncdc
Add remote/util.go helpers to work with KubeConfig Secrets (kubernete…
f9210ed 
…s-sigs#1004)

Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit d48025d)
@vincepri @ncdc
Add remote.ClusterClient to access remote workload clusters (kubernet…
eb57785 
…es-sigs#1006)

Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit 0b25546)
@detiber @ncdc
Add events to MachineSet operations (kubernetes-sigs#1012)
5e064a5 
Add events to the following MachineSet operations
- Adopt Machine
- Create Machine
- Delete Machine

(cherry picked from commit b0170a0)
@vincepri @ncdc
Add patch to events rbac (kubernetes-sigs#1021)
0ddc8ce 
Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit 7365154)
@detiber @ncdc
Update some bazel dependencies (kubernetes-sigs#1019)
47611e2 
(cherry picked from commit 77836d8)
@vincepri @ncdc
Update boilerplate check and generated files (kubernetes-sigs#1010)
e035176 
Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit 0b215f4)
@vincepri @ncdc
Add CLUSTER_API_KUBECONFIG_READY_TIMEOUT to clusterctl (kubernetes-si…
245a447 
…gs#1026)

Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit 9cd85f7)
@detiber @ncdc
Add events to MachineDeployment operations (kubernetes-sigs#1014)
8591410 
(cherry picked from commit a5e5fdb)
@detiber @ncdc
Update controller-runtime and controller-tools (kubernetes-sigs#1032)
b56388a 
(cherry picked from commit da61280)
@akutz @ncdc
Support for wrapped RequeueAfterError/interface (kubernetes-sigs#1020)
3eb8955 
This patch adds support for wrapped "RequeueAfterError" errors
as well as a new interface for supporting custom "RequeueAfterError"
errors.

(cherry picked from commit bd0628f)
@vincepri @ncdc
Use klog in manager and setup controller-runtime logger (kubernetes-s…
0fe1ecd 
…igs#1022)

Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit 0ebf076)
@detiber @ncdc
Bazel updates (kubernetes-sigs#1043)
5e60279 
- Remove use of deprecated bazel attribute label single_file
- Add bazel version checking
- Include go_rules fix for cross-compiling darwin binaries

(cherry picked from commit 2123eed)
@tariq1890 @ncdc
clean up shell scripts in cluster-api (kubernetes-sigs#1045)
9f2b502 
(cherry picked from commit d63d4be)
@vincepri @ncdc
Update k8s/code-generator to latest release-1.13 (kubernetes-sigs#1048)
3b55158 
Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit c2faf86)
@jichenjc @ncdc
downgrade log of util.ExecuteCommand (kubernetes-sigs#975)
be185f2 
As this error E0531 is not that ueful and no need to be mark
this as 'E', use Info level should be fine as this won't affect
return value.

(cherry picked from commit 97f25c9)
@davidewatson @ncdc
Make ClusterNetwork ClusterNetworkingConfig field optional within (ku…
17dfd98 
…bernetes-sigs#919)

Cluster resources. This is useful for Managed Control Planes and
Bare Metal where networking configuration options may be limited.

(cherry picked from commit 9e1eb56)
@vincepri @ncdc
NodeRef controller (kubernetes-sigs#1011)
7137b60 
Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit 9e89546)
@vincepri @ncdc
Update generated files, add workaround for controller-tools (kubernet…
fd525a9 
…es-sigs#1050)

Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit 1c10a3f)
@vincepri @ncdc
Update controller-tools to 0.1.11 (kubernetes-sigs#1053)
7e236c8 
Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit 1cb3deb)
@vincepri @ncdc
Update dep check (kubernetes-sigs#1056)
b270c25 
Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit aecec29)
@posox @ncdc
Fix register bootstrap options in alpha phases (kubernetes-sigs#1064)
6dd53a3 
Fixes issue: kubernetes-sigs#1063

(cherry picked from commit 8141304)
@vincepri @ncdc
Use remote NodeRef in Machine and MachineSet controllers (kubernetes-…
22eb26b 
…sigs#1052)

Signed-off-by: Vince Prignano <[email protected]>
(cherry picked from commit 1eaf864)
@ncdc ncdc requested a review from detiber June 25, 2019 15:50
@k8s-ci-robot
Copy link
Contributor

Welcome @ncdc!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jun 25, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Jun 25, 2019

/uncc @caesarxuchao @deads2k

@ncdc
Bazel fixes
4d5c019 
Signed-off-by: Andy Goldstein <[email protected]>
vincepri
vincepri approved these changes Jun 25, 2019
View reviewed changes
Copy link
Member

@vincepri vincepri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/ok-to-test
/assign @detiber

🎉

@k8s-ci-robot k8s-ci-robot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jun 25, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ncdc, vincepri

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 25, 2019
@detiber
Copy link
Member

detiber commented Jun 25, 2019

/lgtm
/check-cla

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2019
@ncdc
Copy link
Contributor Author

ncdc commented Jun 25, 2019

Something is weird with the bot since it didn't add my CLA status...

I signed it!

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 25, 2019
@k8s-ci-robot k8s-ci-robot merged commit d1b07f4 into kubernetes-sigs:release-0.1 Jun 25, 2019
@ncdc ncdc deleted the 0.1-backports-for-noderef branch September 6, 2019 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vincepri vincepri vincepri approved these changes

@detiber detiber Awaiting requested review from detiber

Assignees

@detiber detiber

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ncdc @k8s-ci-robot @detiber @vincepri @akutz @tariq1890 @jichenjc @davidewatson @posox