-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 [wip] bump controller-gen and regenerate manifests to optimize RBAC #10612
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest to drop the +required from v1alpha3 + v1alpha4 conditions to get rid of the change in the CRDs. Type are internal now anyway
bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigs.yaml
Show resolved
Hide resolved
@chrischdi I would appreciate if we can merge this PR before the other CAPI PR. Because I already verified that all the changes in this PR are correct (apart from the last nit regarding lastTransitionTime + rebase on top of CT main) |
f26c268
to
73d968d
Compare
Rebased to latest master commit for controller-tools. |
/test help |
@chrischdi: The specified target(s) for
The following commands are available to trigger optional jobs:
Use
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/test pull-cluster-api-e2e-main |
One enter too much which closed it... /test pull-cluster-api-e2e-main |
@chrischdi: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/area dependency /hold This should wait for v0.16 of controller-tools (~ August) |
@chrischdi can you please rebase onto latest CAPI & CT main and regenerate? |
73d968d
to
763a0d2
Compare
done :-) |
Interesting, no additional diff (I was wondering if kubernetes-sigs/controller-tools#877 leads to some changes) EDIT: moment, ah looks like it worked (had a problem with pull) |
bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigs.yaml
Show resolved
Hide resolved
@chrischdi I would close this PR and integrate this in #10803 |
/close in favor of #10803 |
@chrischdi: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
uses controller-gen from kubernetes-sigs/controller-tools#937
What this PR does / why we need it:
Bumps controller-gen to commit kubernetes-sigs/controller-tools@ed2fbe2 .
This includes:
Which deduplicates rbac stuff and makes the roles better readable.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Area example:
/area dependency