🌱 Use setup-envtest from CR main (05/2024) to use envtest binaries from CT releases #10569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
|
/hold Going to use it from my fork until the CR PR Is merged: kubernetes-sigs/controller-runtime#2811 |
k8s-ci-robot
added
do-not-merge/needs-area
sbueringer
changed the title
sbueringer
force-pushed
the
pr-envtest-main
branch
2 times, most recently
from
00fd77b
to
df688e1
Compare
k8s-ci-robot
added
size/M
sbueringer
commented
May 7, 2024
sbueringer
changed the title
k8s-ci-robot
added
the
do-not-merge/work-in-progress
sbueringer
force-pushed
the
pr-envtest-main
branch
from
df688e1
to
9e44e55
Compare
k8s-ci-robot
added
size/XS
sbueringer
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @chrischdi @fabriziopandini |
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
… CT releases Signed-off-by: Stefan Büringer [email protected]
sbueringer
force-pushed
the
pr-envtest-main
branch
from
9e44e55
to
3894076
Compare
This was referenced May 22, 2024
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 8999fce65e18f9f10802e10ca6ec850baf2d00a5
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
This was referenced May 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Context: kubernetes-sigs/controller-runtime#2811
I'm going to backport this to all branches (and also CAPV)
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #