-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
📖 Improve clarity of prowjob configuration regeneration instructions #10358
📖 Improve clarity of prowjob configuration regeneration instructions #10358
Conversation
Hi @Sunnatillo. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @chrischdi |
Signed-off-by: Sunnatillo <[email protected]>
e3b391b
to
c515861
Compare
/ok-to-test |
/lgtm |
LGTM label has been added. Git tree hash: 7f808e45dd89d50f8cd0a87a2192ed5837a3ee5c
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Totally fine as is, but in general let's try to not link too much to PRs for documentation and rather properly document things. It's a bit annoying to have to go through PR diffs to gather additional context. (it's fine for prior art and in some other cases. It just becomes annoying over time if we use this too much) |
What this PR does / why we need it:
Adds more explanation on how to generate prowjob configuration on release-tasks.md file
Area example:
/area documentation