-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Allow tilt provider with pre-build images #10244
🌱 Allow tilt provider with pre-build images #10244
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nits
/approve cancel |
7077c9c
to
b0bbf9d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
/hold feel free to unhold
LGTM label has been added. Git tree hash: d48a414c7e052c62a328e8908a919420e1642ebe
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@fabriziopandini Just to confirm. This can be used by not specifying image, live_reload_deps and debug settings (in tilt-settings.yaml) for a provider? |
Yes, if you omit image, then live_reload_deps and debug do not make sense anymore. |
What this PR does / why we need it:
With this PR it is now possible to use tilt providers with probuilt images (images already pushed somewhere, not manage by tilt build_docker_image).
This is useful for test published images, and it came at the cost that for those images it is not possible to activate debud/live reload, which is acceptable for the given use case.
/area devtools