🐛 Reverting ginkgo.show-node-events to ginkgo.progress #10214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
|
/area testing |
k8s-ci-robot
added
area/testing
chrischdi
reviewed
Feb 29, 2024
| @@ -1,7 +1,7 @@ | |||
| ginkgo.focus: \[Conformance\] | |||
| ginkgo.skip: \[Serial\] | |||
| disable-log-dump: true | |||
| ginkgo.show-node-events: true | |||
| ginkgo.progress: true | |||
There was a problem hiding this comment.
Let's add a comment that this is still used as long as we run kubetest on versions <= v1.26.
There was a problem hiding this comment.
added the comment. Please check
Signed-off-by: muhammad adil ghaffar <[email protected]>
adilGhaffarDev
force-pushed
the
revert-ginkgo-deprec/adil
branch
from
ea1eac9 to
35c2606
Compare
k8s-ci-robot
added
size/S
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 84b7cf760260a8ccac5777fe8e5d1d997b889b97
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Reverting ginkgo.show-node-events to ginkgo.progress, because older versions of the kubetest images we use (depends on k8s version) have a too old ginkgo version. Tests are failing because of it: https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/periodic-cluster-api-e2e-upgrade-1-24-1-25-main/1762531387493060608
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #