-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 add hivelocity infra provider to clusterctl #10168
🌱 add hivelocity infra provider to clusterctl #10168
Conversation
Hi @kranurag7. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/ok-to-test
Signed-off-by: kranurag7 <[email protected]>
Signed-off-by: kranurag7 <[email protected]>
Signed-off-by: kranurag7 <[email protected]>
Signed-off-by: kranurag7 <[email protected]>
ccef514
to
adf7cd2
Compare
/test pull-cluster-api-test-main |
Signed-off-by: kranurag7 <[email protected]>
/tide merge-method-squash /lgtm |
LGTM label has been added. Git tree hash: d9397120a61d87447564a303c3d553fd146819ad
|
@chrischdi I think in this case manual squashing is not required from my end. I was thinking of doing it, once the checks are green. |
The label adding did not really work, but yeah should not be required :-) /tide merge-method-squash |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/cherry-pick release-1.6 |
@fabriziopandini: once the present PR merges, I will cherry-pick it on top of release-1.6 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@fabriziopandini: #10168 failed to apply on top of branch "release-1.6":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
* add hivelocity infra provider to clusterctl Signed-off-by: kranurag7 <[email protected]> * fix spaces Signed-off-by: kranurag7 <[email protected]> * update provider name Signed-off-by: kranurag7 <[email protected]> * use updated syntax for naming infra provider Signed-off-by: kranurag7 <[email protected]> * address review comments Signed-off-by: kranurag7 <[email protected]> --------- Signed-off-by: kranurag7 <[email protected]>
* add hivelocity infra provider to clusterctl Signed-off-by: kranurag7 <[email protected]> * fix spaces Signed-off-by: kranurag7 <[email protected]> * update provider name Signed-off-by: kranurag7 <[email protected]> * use updated syntax for naming infra provider Signed-off-by: kranurag7 <[email protected]> * address review comments Signed-off-by: kranurag7 <[email protected]> --------- Signed-off-by: kranurag7 <[email protected]>
* add hivelocity infra provider to clusterctl Signed-off-by: kranurag7 <[email protected]> * fix spaces Signed-off-by: kranurag7 <[email protected]> * update provider name Signed-off-by: kranurag7 <[email protected]> * use updated syntax for naming infra provider Signed-off-by: kranurag7 <[email protected]> * address review comments Signed-off-by: kranurag7 <[email protected]> --------- Signed-off-by: kranurag7 <[email protected]>
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #10167
/area clusterctl