-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Use manager in test extension #10097
🌱 Use manager in test extension #10097
Conversation
/assign @fabriziopandini @chrischdi |
84f374c
to
0e2526d
Compare
/test pull-cluster-api-e2e-main |
Nice! awesome to to see the runtime extensions catching up with the rest of capi, getting liveness/readiness probes, settings for TLS, client-go QPS and burst etc. |
LGTM label has been added. Git tree hash: cfeee329d85f8e357f32e4fee157203eb3a154c3
|
Signed-off-by: Stefan Büringer [email protected]
0e2526d
to
37e64cc
Compare
Looks like I broke RBAC. Another try... /test pull-cluster-api-e2e-main |
@sbueringer: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Should be fine now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
LGTM label has been added. Git tree hash: c8fe44ee82254ac16cfa904af22537b3beda0690
|
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chrischdi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Going to cherry-pick this as an improvement of our test code. The changes in exp/runtime/server/server.go are compatible (and it's also an experimental feature/package) /cherry-pick release-1.6 |
@sbueringer: new pull request created: #10106 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Stefan Büringer [email protected]
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #7258