Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

📖 Add OpenStack to External Cloud Providers in quick-start.md #10061

Merged
merged 1 commit into from
Feb 12, 2024
Merged

📖 Add OpenStack to External Cloud Providers in quick-start.md #10061

merged 1 commit into from
Feb 12, 2024

Conversation

maxrantil
Copy link
Contributor

@maxrantil maxrantil commented Jan 26, 2024 •
edited
Loading

What this PR does / why we need it:
Provides instructions for users to set up OpenStack as an external cloud provider.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-area PR is missing an area label labels Jan 26, 2024
@k8s-ci-robot
Copy link
Contributor

Welcome @maxrantil!

It looks like this is your first PR to kubernetes-sigs/cluster-api 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @maxrantil. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 26, 2024
@k8s-ci-robot
Copy link
Contributor

@maxrantil: The label(s) area/openstack cannot be applied, because the repository doesn't have them.

In response to this:

/area openstack

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@maxrantil
Copy link
Contributor Author

/area documentation
/area provider/openstack

@k8s-ci-robot k8s-ci-robot added area/documentation Issues or PRs related to documentation area/provider/openstack Issues or PRs related to openstack provider and removed do-not-merge/needs-area PR is missing an area label labels Jan 26, 2024
killianmuldoon
killianmuldoon reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 26, 2024
lentzi90
lentzi90 reviewed Jan 26, 2024
View reviewed changes
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Outdated Show resolved Hide resolved
docs/book/src/user/quick-start.md Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 26, 2024
lentzi90
lentzi90 reviewed Jan 26, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From CAPO's side I would say this looks good!
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 26, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 588a2204f621ef8731020e536c6760a9454f84d5

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 2, 2024
@k8s-ci-robot k8s-ci-robot requested a review from lentzi90 February 2, 2024 14:07
@maxrantil
Copy link
Contributor Author

Got a little bit of problems with the git squash, but everything should be in order now. Thanks for the feedback everybody.

lentzi90
lentzi90 reviewed Feb 5, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 5, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 642f09a548a309fcc0208317609b0426eccee188

@fabriziopandini
Copy link
Member

/lgtm

@chrischdi
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: chrischdi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 7, 2024
@chrischdi
Copy link
Member

/hold if you want other OpenStack folks to review.

Feel free to unhold if you're ok.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2024
@maxrantil
Copy link
Contributor Author

@mdbooth Do you find this looking good too?

@EmilienM
Copy link

EmilienM commented Feb 9, 2024

/lgtm

@lentzi90 @chrischdi
Add OpenStack to External Cloud Providers in quick-start.md
7371e3a 
Provides instructions for users to set up OpenStack as an
external cloud provider.

Signed-off-by: Max Rantil <[email protected]>
Co-authored-by: Lennart Jern <[email protected]>
Co-authored-by: Christian Schlotter <[email protected]>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2024
lentzi90
lentzi90 reviewed Feb 12, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 12, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: deff1f1e7b96ef44da33e114f198f8180ceb15a8

@lentzi90
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 12, 2024
@k8s-ci-robot k8s-ci-robot merged commit 4a84453 into kubernetes-sigs:main Feb 12, 2024
17 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.7 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@chrischdi chrischdi chrischdi left review comments

@dulek dulek dulek left review comments

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@EmilienM EmilienM Awaiting requested review from EmilienM

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

Assignees

@EmilienM EmilienM

@fabriziopandini fabriziopandini

@lentzi90 lentzi90

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/documentation Issues or PRs related to documentation area/provider/openstack Issues or PRs related to openstack provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.7
Development

Successfully merging this pull request may close these issues.
8 participants
@maxrantil @k8s-ci-robot @fabriziopandini @chrischdi @EmilienM @lentzi90 @dulek @killianmuldoon