-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove example from --runtime-extension flag in clusterctl #9796
Comments
runtime-extension-components
to default runtime extenstion providersruntime-extension-components
to default runtime extension providers
/kind feature |
Sounds good! /triage accepted |
/assign cahillsf |
I don't think we should expose test extensions without some docs about what they are and how to use them. Frankly speaking, I would simply remove the example from the flag description, plus eventually add a note that clusterctl doesn't include any default runtime extensions.
|
I'm fine either way. The reason I wrote sounds good is because I thought it is similar to CAPD. |
They are the kind the same, but for CAPD we have a quick start doc that tells users when and how to use CAPD (while we don't have an equivalent for test extensions). |
Makes sense and I agree. Let's keep it "more internal" for the time being. |
sounds good, ill close out the existing PR and cut a new one with the doc/help text update suggested |
runtime-extension-components
to default runtime extension providers
/good-first-issue |
@fabriziopandini: GuidelinesPlease ensure that the issue body includes answers to the following questions:
For more details on the requirements of such an issue, please see here and ensure that they are met. If this request no longer meets these requirements, the label can be removed In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign avaneesh634 |
The
clusterctl
help text for the--runtime-extension
options provides an example:Runtime extension providers and versions (e.g. test:v0.0.1) to add to the management cluster.
Applying this option and example param results in the following error:
Error: failed to get configuration for the RuntimeExtensionProvider with name test. Please check the provider name and/or add configuration for new providers using the .clusterctl config
The text was updated successfully, but these errors were encountered: