Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile improvement suggestions #945

Closed
ncdc opened this issue May 14, 2019 · 3 comments
Closed

Makefile improvement suggestions #945

ncdc opened this issue May 14, 2019 · 3 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.

Comments

@ncdc
Copy link
Contributor

ncdc commented May 14, 2019

/kind feature

Describe the solution you'd like
I'd like to propose some changes to our Makefile targets:

  • If I'm compiling locally, I only want the clientsets/listers/informers regenerated as-needed; in other words, do not regenerate every time I run any sort of build-related target. The same applies to the go generate output.
  • If I'm compiling locally, I only want to deal with dep as-needed; in other words, do not run dep ensure unless I explicitly ask for it.

tl;dr: try to speed up builds by switching targets that aren't needed frequently to optional/opt-in instead of as dependencies

Anything else you would like to add:
N/A

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label May 14, 2019
@timothysc timothysc added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jun 21, 2019
@timothysc timothysc added this to the v1alpha2 milestone Jun 21, 2019
@timothysc timothysc added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Jun 21, 2019
@asauber
Copy link

asauber commented Jun 21, 2019

cc myself

@ncdc
Copy link
Contributor Author

ncdc commented Aug 19, 2019

Much of this has been cleaned up in master. If there's anything left over, I'll either open a new issue, or just file PRs 😄

/close

@k8s-ci-robot
Copy link
Contributor

@ncdc: Closing this issue.

In response to this:

Much of this has been cleaned up in master. If there's anything left over, I'll either open a new issue, or just file PRs 😄

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

No branches or pull requests

5 participants