Improve description for machine deployment.spec.strategy.type

[jayunit100]

What steps did you take and what happened?

For folks doing things w/ i.e. GPU where theres resource constraints its important to know the alterantvies RolloutStrategies....

kubo@PmilRMT2e4lE2:~$ kubectl explain md.spec.strategy
KIND:     MachineDeployment
VERSION:  cluster.x-k8s.io/v1beta1

RESOURCE: strategy <Object>

DESCRIPTION:
     The deployment strategy to use to replace existing machines with new ones.

FIELDS:
   rollingUpdate        <Object>
     Rolling update config params. Present only if MachineDeploymentStrategyType
     = RollingUpdate.


*** WHAT ELSE :) ***

   type <string>
     Type of deployment. Default is RollingUpdate.

kubo@PmilRMT2e4lE2:~$ kubectl explain md.spec.strategy.type
KIND:     MachineDeployment
VERSION:  cluster.x-k8s.io/v1beta1

FIELD:    type <string>

DESCRIPTION:
     Type of deployment. Default is RollingUpdate.

What did you expect to happen?

The description would have valid rollout values since they are strongly typed

Cluster API version

cluster-api/cluster-api-controller:v1.4.5

Kubernetes version

No response

Anything else you would like to add?

No response

Label(s) to be applied

/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

[fabriziopandini]

/triage accepted

The OnDelete strategy doesn't have options, so there is no missing types.

But let's change

cluster-api/api/v1beta1/machinedeployment_types.go

Line 155 in 58557b7

// Type of deployment.

into

// Type of deployment, allowed values RollingUpdate, OnDelete. Default is RollingUpdate.

/help
/good-first-issue

[k8s-ci-robot]

@fabriziopandini:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/triage accepted

Let's change

cluster-api/api/v1beta1/machinedeployment_types.go

Line 155 in 58557b7

// Type of deployment.

into

// Type of deployment, allowed values RollingUpdate, OnDelete. Default is RollingUpdate.

/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.