Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cli flag to supply namespace for capi controller to watch for Objects #912

Closed
DheerajSShetty opened this issue Apr 23, 2019 · 8 comments · Fixed by #914
Closed

Add cli flag to supply namespace for capi controller to watch for Objects #912

DheerajSShetty opened this issue Apr 23, 2019 · 8 comments · Fixed by #914
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.

Comments

@DheerajSShetty
Copy link

/kind feature
Add cli flag to supply namespace for capi controller to watch for Objects

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 23, 2019
@detiber
Copy link
Member

detiber commented Apr 23, 2019

Currently we hard code the lister to watch for updates in all Namespaces, We should expose the ability to set a specific namespace using the manager command line arguments that is passed to the lister to limit to a specific namespace.

@vikaschoudhary16
Copy link
Contributor

/assign

@k8s-ci-robot
Copy link
Contributor

@vikaschoudhary16: GitHub didn't allow me to assign the following users: vikaschoudhary16.

Note that only kubernetes-sigs members and repo collaborators can be assigned and that issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vikaschoudhary16
Copy link
Contributor

@detiber can you please assign this to me, if anyone is not working already.

@vikaschoudhary16
Copy link
Contributor

@detiber
Copy link
Member

detiber commented Apr 24, 2019

/assign
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Apr 24, 2019
@detiber
Copy link
Member

detiber commented Apr 24, 2019

@vikaschoudhary16 I've assigned it to myself (since it doesn't appear that you are a member of the kubernetes-sigs org), and marked it as active.

If you are already a member of the kubernetes org, you can request to be added to the kubernetes-sigs org as well. If not, I'm also happy to sponsor you for membership in kubernetes-sigs.

@detiber
Copy link
Member

detiber commented Apr 24, 2019

@vikaschoudhary16 this shouldn't require any changes to controller-runtime. Here is how we added the support to cluster-api-provider-aws: kubernetes-sigs/cluster-api-provider-aws#607 and kubernetes-sigs/cluster-api-provider-aws#615

vikaschoudhary16 added a commit to vikaschoudhary16/cluster-api that referenced this issue Apr 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants