Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make timeoutMachineReady configurable #860

Closed
gyliu513 opened this issue Mar 29, 2019 · 3 comments
Closed

Make timeoutMachineReady configurable #860

gyliu513 opened this issue Mar 29, 2019 · 3 comments
Assignees
@jichenjc
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.

Comments

@gyliu513
Copy link
Contributor

gyliu513 commented Mar 29, 2019 •
edited
Loading

/kind feature

Describe the solution you'd like
[A clear and concise description of what you want to happen.]

Currently, the timeout of timeoutMachineReady is 30 mins, it is better make this configurable, so that customer can use a larger value for some IaaS layer which need more time to make machine and k8s ready.

/cc @vincepri @detiber

FYI @jichenjc @morvencao @xunpan @clyang82

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Mar 29, 2019
@vincepri vincepri added this to the Next milestone Mar 29, 2019
@vincepri vincepri added priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 29, 2019
@jichenjc
Copy link
Contributor

jichenjc commented Apr 1, 2019

/assign

jichenjc added a commit to jichenjc/cluster-api that referenced this issue Apr 1, 2019
@jichenjc
Add timeout param for create machine
60b816f 
Add timeout for create machine param, so that we won't have a
fixed time for timeout, user can give param on timeout

Fix Bug kubernetes-sigs#860
jichenjc added a commit to jichenjc/cluster-api that referenced this issue Apr 1, 2019
@jichenjc
Add timeout param for create machine
0977b70 
Add timeout for create machine param, so that we won't have a
fixed time for timeout, user can give param on timeout

Fix Bug kubernetes-sigs#860
@gyliu513 gyliu513 mentioned this issue Apr 1, 2019
Merged
@jichenjc
Copy link
Contributor

I forgot to add mark in #865 ,but since it's merged, we can close this one? @gyliu513

@gyliu513
Copy link
Contributor Author

Yes, let me close it. thanks @jichenjc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jichenjc jichenjc

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@vincepri @gyliu513 @jichenjc @k8s-ci-robot