Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up tasks for CR bump to v0.14.0 #7925

Closed
4 tasks done
sbueringer opened this issue Jan 16, 2023 · 6 comments
Closed
4 tasks done

Follow-up tasks for CR bump to v0.14.0 #7925

sbueringer opened this issue Jan 16, 2023 · 6 comments
Assignees
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@sbueringer
Copy link
Member

sbueringer commented Jan 16, 2023

This issue contains some follow-up tasks which should be done after we bumped to the CR v0.14.0 release

Prereqs:

Tasks:

/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 16, 2023
@sbueringer
Copy link
Member Author

/assign
/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 16, 2023
@sbueringer
Copy link
Member Author

Moved v0.15 stuff to #8093

@sbueringer
Copy link
Member Author

Regarding: Check if we can simplify unit tests now that the fake client supports indexes

Technically we could refactor some tests to use fake client instead of test env. Mainly the ClusterClass webhook unit tests that we had to implement with envtest. But to be honest I don't see enough upside to invest the effort in migrating those tests to fakeclient.

(cc @killianmuldoon)

@sbueringer
Copy link
Member Author

Regarding: Verify the kubeconfig change works as expected

Verified the behavior and --kubeconfig works as expected for us

@sbueringer
Copy link
Member Author

/close

given comments above

@k8s-ci-robot
Copy link
Contributor

@sbueringer: Closing this issue.

In response to this:

/close

given comments above

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

2 participants