Crash on startup from ClusterResourceSetBindingController

[killianmuldoon]

Using backup and restore on a workload cluster with a ClusterResourceSet and ClusterResourceSetBinding which resulted in a crash on startup in the ClusterResourceSetBinding controller. The issue is a nil pointer exception due to insufficient nil checking around

cluster-api/exp/addons/internal/controllers/clusterresourcesetbinding_controller.go

Line 85 in f072182

if apierrors.IsNotFound(err) || !cluster.DeletionTimestamp.IsZero() {

Both cluster and error can be nil from the GetOwnerCluster function but this is not caught by our checks.

/good-first-issue

/kind bug

[k8s-ci-robot]

@killianmuldoon:
This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

Using backup and restore on a workload cluster with a ClusterResourceSet and ClusterResourceSetBinding which resulted in a crash on startup in the ClusterResourceSetBinding controller. The issue is a nil pointer exception due to insufficient nil checking around

cluster-api/exp/addons/internal/controllers/clusterresourcesetbinding_controller.go

Line 85 in f072182

if apierrors.IsNotFound(err) || !cluster.DeletionTimestamp.IsZero() {

Both cluster and error can be nil from the GetOwnerCluster function but this is not caught by our checks.

/good-first-issue

/kind bug

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[killianmuldoon]

Related: https://community.pivotal.io/s/article/5000e00001pJyN41611954332537?language=en_US

[fabriziopandini]

Good catch! this is a candidate for backporting, also putting in the release as blocking, but we can re-evaluate near release

/milestone v1.1
/kind release-blocking

[aartij17]

/assign @AartiJivrajani