Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support more strategies [UpgradeOnChange] on ClusterResourceSet #5467

Closed
sadysnaat opened this issue Oct 21, 2021 · 5 comments
Closed

Support more strategies [UpgradeOnChange] on ClusterResourceSet #5467

sadysnaat opened this issue Oct 21, 2021 · 5 comments
Assignees
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@sadysnaat
Copy link
Contributor

User Story

As a user I would like to reapply resources when I update underlying ResourceReference secret or configmap data

Detailed Description

I am capv operator and I deploy CNI and CSI using clusterresourceset,
now using applyonce strategy capi ensures that these
resources are applied to cluster once

But if I change/update say CSI image tags for newer release the resources will not be updated

I would like to update my resources on such changes

So I propose to implement a new Strategy for ClusterResourceSet UpgradeOnChange

UpgradeOnChange behaves like ApplyOnce on first creation
and later if there are changes in the contents of ResourceReference

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Oct 21, 2021
@sadysnaat
Copy link
Contributor Author

/assign @sadysnaat

@kbreit
Copy link

kbreit commented Oct 21, 2021

This sounds similar to #4807. Would you say it's different outside of the terms it uses (continuous v onChange)?

@sadysnaat
Copy link
Contributor Author

Yes @kbreit this is similar to #4807 we can close this issue, I can help pick up #4807 prepare a doc for changes, wdyt?

@vincepri
Copy link
Member

/close
Closing favor of #4807

@k8s-ci-robot
Copy link
Contributor

@vincepri: Closing this issue.

In response to this:

/close
Closing favor of #4807

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

4 participants