-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate internal/matchers into Komega style test abstraction in Controller Runtime #5338
Comments
Should we open an issue in Controller Runtime as well? |
Will do - I'm doing an initial spec test to get a feel for what the integration would look like today, and then I'll put a PR up over there. |
/milestone Next |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/reopen |
@sbueringer: Reopened this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/close |
@killianmuldoon: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@killianmuldoon Should we track it somewhere that we actually use it? :) |
User Story
As a developer I would like to have a consistent abstract toolset to quickly write unit tests in Cluster API.
Detailed Description
The matchers package added in #5259 brings generic matching to Cluster API objects and makes it easier to match only on required fields at test time. In controller runtime a similar approach with some differences - called Komega in its current iteration at kubernetes-sigs/controller-runtime#1364
These approaches could be integrated inside controller runtime to bring generic json based matching with the Komega abstraction over the controller runtime client to reduce the amount of boiler plate code involved in writing these tests.
/kind feature
/area testing
The text was updated successfully, but these errors were encountered: