-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go get / go install for projects depending on capi does not work #5184
Comments
Can you expand on this? Another solution I'm seeing is to avoid doing this for release versions of a project so that go install etc. will work for release versions but this easier method of testing the latest code can be used for whatever the local version is. c/f |
Basically what any consumer needs to do today, e.g any provider https://github.com/kubernetes-sigs/cluster-api-provider-aws/blob/main/go.mod#L5
Sounds interesting. This should possible be pointing to a pinned version https://github.com/kubernetes-sigs/cluster-api/blob/v0.4.2/test/go.mod#L5 |
@fabriziopandini do you think we could update the release tools to pin this version for each release? |
@killianmuldoon What did you have in mind to do the above? The current release process happens after the tag is published |
I was thinking maybe adding something to change this line in go.mod under 'make release' - but with the ordering there will be drift with the go.mod. |
/milestone Next |
The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages issues and PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
/close |
@sbueringer: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What steps did you take and what happened:
What did you expect to happen:
go get / go install works
Anything else you would like to add:
This is the controversial clause https://github.com/kubernetes-sigs/cluster-api/blob/master/test/go.mod#L5
This can be workaround by adding a replace clause for capi in the invoking go.mod file. Nevertheless I'd expect us to provide a better solution so this commands work out of the box.
Environment:
kubectl version
):/etc/os-release
):/kind bug
[One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels]
The text was updated successfully, but these errors were encountered: