Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reconciler key to the loggers of all reconcilers #5147

Closed
sbueringer opened this issue Aug 24, 2021 · 2 comments · Fixed by #5151
Closed

Add reconciler key to the loggers of all reconcilers #5147

sbueringer opened this issue Aug 24, 2021 · 2 comments · Fixed by #5151
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.

Comments

@sbueringer
Copy link
Member

User Story

As a user I would like to be able to distinguish logs of different reconcilers

Detailed Description

In #5134 we'll add a reconciler: topology/ClusterReconciler k/v pair to the topology.ClusterReconciler logger. Let's also add the reconciler k/v pair to all our other reconcilers.

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind cleanup
/help

@k8s-ci-robot
Copy link
Contributor

@sbueringer:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

User Story

As a user I would like to be able to distinguish logs of different reconcilers

Detailed Description

In #5134 we'll add a reconciler: topology/ClusterReconciler k/v pair to the topology.ClusterReconciler logger. Let's also add the reconciler k/v pair to all our other reconcilers.

Anything else you would like to add:

[Miscellaneous information that will assist in solving the issue.]

/kind cleanup
/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Aug 24, 2021
@killianmuldoon
Copy link
Contributor

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants