Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused DNSAddOnType constants from kubeadm/v1alpha4 #4546

Closed
ludusrusso opened this issue Apr 29, 2021 · 1 comment · Fixed by #4547
Closed

Remove unused DNSAddOnType constants from kubeadm/v1alpha4 #4546

ludusrusso opened this issue Apr 29, 2021 · 1 comment · Fixed by #4547

Comments

@ludusrusso
Copy link
Contributor

ludusrusso commented Apr 29, 2021

User Story

As a developer I would like to live the code to be as simple as possible. In my PR #4516 I left this piece of code from v1alpha4 that I think can be safely removed:

// DNSAddOnType defines string identifying DNS add-on types.
type DNSAddOnType string
const (
// CoreDNS add-on type.
CoreDNS DNSAddOnType = "CoreDNS"
// KubeDNS add-on type.
KubeDNS DNSAddOnType = "kube-dns"
)

@fabriziopandini if you are ok with this I can submit a PR!

@sbueringer
Copy link
Member

@ludusrusso If those are just unused constants, you can go ahead and open a PR to drop them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants