More unit test coverage for clusterctl upgrader

[shysank]

User Story

Right now, the unit tests for upgrader (upgrader_test.go) has tests for Plan, and createCustomPlan methods. We want to add more coverage by adding tests for the other methods in the ProviderUpgrader interface namely: ApplyPlan, and ApplyCustomPlan methods.

#4230 partially addresses this by adding failure cases specific to running multiple provider instance version for v1alpha4 upgrade. But, we also need to have test cases for success scenarios.

Anything else you would like to add:

The main challenge here to create a fake for getUpgradeComponents and installComponentsAndUpdateInventory.

/kind feature

[fabriziopandini]

/area clusterctl
/priority backlog
/milestone v0.4.0
(putting in the milestone for now, but it doesn't sees a blocker for me so we can move it later if there is no bandwidth)

/help

[k8s-ci-robot]

@fabriziopandini:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/area clusterctl
/priority backlog
/milestone v0.4.0
(putting in the milestone for now, but it doesn't sees a blocker for me so we can move it later if there is no bandwidth)

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[fejta-bot]

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

[sbueringer]

/remove-lifecycle stale

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

• Mark this issue or PR as fresh with /remove-lifecycle stale
• Mark this issue or PR as rotten with /lifecycle rotten
• Close this issue or PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

[vincepri]

/lifecycle frozen

[vincepri]

/milestone v1.0

[fabriziopandini]

/close
We don't have feedback about errors in this area, so the coverage that we have should be already enough

[k8s-ci-robot]

@fabriziopandini: Closing this issue.

In response to this:

/close
We don't have feedback about errors in this area, so the coverage that we have should be already enough

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.