Invalid ProviderID error is malformed

[benmoss]

What steps did you take and what happened:
Have a provider write a ProviderID that doesn't match the form we describe in https://github.com/kubernetes-sigs/cluster-api/blob/master/controllers/noderefutil/providerid.go

See a confusing error in the logs:

controller.go:257] controller-runtime/controller "msg"="Reconciler error" "error"="providerID must be of the form \u003ccloudProvider\u003e://\u003coptional\u003e/\u003csegments\u003e/\u003cprovider id\u003e" "controller"="machine" "name"="bmo-md-1-6bf4fd585d-jfwbx" "namespace"="default"

What did you expect to happen:
I think we just want it to print out the error string verbatim, I don't know where the formatting strings are coming from.

Anything else you would like to add:
I remember fixing this in klog ages ago. Maybe we just need to bump that? kubernetes/klog#139

/kind bug

[vincepri]

/help
/good-first-issue
/milestone v0.4.0

[k8s-ci-robot]

@vincepri:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

/help
/good-first-issue
/milestone v0.4.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[enyinna1234]

I'd like to work on this.
/assign
/lifecycle active

[fabriziopandini]

/lifecycle active
/assign @enyinna1234

[enyinna1234]

@benmoss I'm not able to reproduce this. Can you please shed more light? What provider did you use? I can't find where the NewProviderID function gets called that involves json marshaling.

[vincepri]

/milestone v0.4.x

[benmoss]

@enyinna1234 sorry for the delay, I think in my case this was being logged here. The issue is that klog had a bug that got fixed a while ago but this project hasn't bumped it's klog dependency in a while

[stmcginnis]

/lifecycle active
/assign