Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements test for self-hosted upgrades #3728

Closed
fabriziopandini opened this issue Oct 1, 2020 · 16 comments · Fixed by #7239
Closed

Implements test for self-hosted upgrades #3728

fabriziopandini opened this issue Oct 1, 2020 · 16 comments · Fixed by #7239
Assignees
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented Oct 1, 2020

As of today in CAPI e2e we are testing the bootstrap-pivot to self-hosting sequence, but we are not testing self-hosting upgrades.

Ideally we should test:

  • upgrading a single control plane, self-hosted cluster
  • upgrading an HA control plane, self-hosted cluster

/kind feature
/area testing

@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/testing Issues or PRs related to testing labels Oct 1, 2020
@vincepri
Copy link
Member

vincepri commented Oct 1, 2020

/milestone v0.4.0
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added this to the v0.4.0 milestone Oct 1, 2020
@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Oct 1, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Dec 30, 2020
@fabriziopandini
Copy link
Member Author

/remove-lifecycle stale

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jan 4, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 4, 2021
@fabriziopandini
Copy link
Member Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 6, 2021
@tcordeu
Copy link
Contributor

tcordeu commented May 21, 2021

@fabriziopandini can I work on this one? If so, can you provide some tips on where to start?

@fabriziopandini
Copy link
Member Author

fabriziopandini commented May 21, 2021

Sure!
Currently in out e2e we are testing pivot a management cluster to a self hosted cluster, see https://github.com/kubernetes-sigs/cluster-api/blob/master/test/e2e/self_hosted.go (*), however, after pivoting, we don't do any operation on the self hosted managed cluster (apart from checking it is reconciling itself).

(*) Note that we cannot pivot the kind management cluster generated by our E2E test suite, because it is shared by many test running in parallel. So during the test we are:

  • creating a workload cluster
  • turning it into a management cluster (our starting cluster for pivoting)
  • using it to create another workload cluster (the target cluster for pivoting)
  • doing the pivot:
    • turn this second cluster into a management cluster
    • move the cluster definitions from the starting point to here

This issue is about:

  • Extending this test, by adding a final step that upgrades the self hosted cluster (the target cluster after pivot).
  • Making required changes so we can run the same test twice, one with 1 cp machines, one with 3 cp machines

/assign @tcordeu
/lifecycle active

@k8s-ci-robot k8s-ci-robot added lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels May 21, 2021
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. labels Aug 19, 2021
@fabriziopandini
Copy link
Member Author

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Aug 20, 2021
@fabriziopandini
Copy link
Member Author

/unassign @tcordeu
/assign @anusha94

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: GitHub didn't allow me to assign the following users: anusha94.

Note that only kubernetes-sigs members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/unassign @tcordeu
/assign @anusha94

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@anusha94
Copy link
Contributor

anusha94 commented Oct 7, 2021

/assign @anusha94

@vincepri
Copy link
Member

/milestone v1.0

@k8s-ci-robot k8s-ci-robot modified the milestones: v0.4, v1.0 Oct 19, 2021
@vincepri vincepri modified the milestones: v1.0, v1.1 Oct 22, 2021
@fabriziopandini fabriziopandini modified the milestones: v1.1, v1.2 Feb 3, 2022
@fabriziopandini fabriziopandini added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 29, 2022
@fabriziopandini fabriziopandini removed this from the v1.2 milestone Jul 29, 2022
@fabriziopandini fabriziopandini removed the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 29, 2022
@fabriziopandini
Copy link
Member Author

/triage accepted

@k8s-ci-robot k8s-ci-robot added the triage/accepted Indicates an issue or PR is ready to be actively worked on. label Jul 29, 2022
@chrischdi
Copy link
Member

@anusha94 are you still working at this?

@chrischdi
Copy link
Member

Taking this over as there was no response :-)

/unassign @anusha94
/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing Issues or PRs related to testing kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
8 participants