Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve MHC e2e tests #3656

Closed
fabriziopandini opened this issue Sep 17, 2020 · 10 comments · Fixed by #4094
Closed

Improve MHC e2e tests #3656

fabriziopandini opened this issue Sep 17, 2020 · 10 comments · Fixed by #4094
Assignees
@fabriziopandini
Labels
area/testing Issues or PRs related to testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Milestone
v0.4

Comments

@fabriziopandini
Copy link
Member

The current MHC object in E2E tests is specifically configured to always trigger remediation after 30s the node is started.

cluster-api/test/e2e/data/infrastructure-docker/bases/mhc.yaml

Lines 15 to 18 in 0cf9f80

unhealthyConditions:
- type: E2ENodeUnhealthy
status: "True"
timeout: 30s

As per comment #3651 (review)

Can we revisit this? I understand the goal here is to make MHC fail and remediate after 30s, but if we could actually flip this to control when this happens and reduce the timeout, that would probably be better?

For example, our tests could be a little bit more controlled if we apply the unhealthy condition, wait for the timeout, and ultimately check that health check or remediation happened.

/kind feature
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 17, 2020
@fabriziopandini
Copy link
Member Author

/help
/priority backlog
/milestone Next

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/priority backlog
/milestone Next

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Sep 17, 2020
@k8s-ci-robot k8s-ci-robot added this to the Next milestone Sep 17, 2020
@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Sep 17, 2020
@fabriziopandini fabriziopandini mentioned this issue Sep 17, 2020
Merged
@vincepri
Copy link
Member

/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot modified the milestones: Next, v0.4.0 Sep 17, 2020
@vincepri
Copy link
Member

/area testing
/kind cleanup

@k8s-ci-robot k8s-ci-robot added area/testing Issues or PRs related to testing kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 17, 2020
@vincepri vincepri removed the kind/feature Categorizes issue or PR as related to a new feature. label Sep 17, 2020
@fabriziopandini
Copy link
Member Author

This work should possible address also testing for KCP remediation

@tcordeu
Copy link
Contributor

tcordeu commented Dec 26, 2020

@fabriziopandini Going to work on this issue, feel free to unassign me if someone is working on it!

/assign @tcordeu
/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Dec 26, 2020
@vincepri
Copy link
Member

vincepri commented Jan 4, 2021

Thank you @tcordeu !

@fabriziopandini
Copy link
Member Author

@tcordeu are you still working on this issue?
I'm working on #3913 and given that the two things are strictly related I can tackle this as well

@tcordeu
Copy link
Contributor

tcordeu commented Jan 20, 2021

Go ahead!

/unassign

@fabriziopandini
Copy link
Member Author

/assign
/lifecycle active

@fabriziopandini fabriziopandini mentioned this issue Jan 20, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fabriziopandini fabriziopandini

Labels
area/testing Issues or PRs related to testing help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

🌱 Add E2E test for KCP remediation fabriziopandini/cluster-api
4 participants
@vincepri @fabriziopandini @k8s-ci-robot @tcordeu