References to Machine spec.kubernetesVersion seems misleading

[wfernandes]

What steps did you take and what happened:
In the following files we reference spec.kubernetesVersion for the Machine object. But I don't believe we have that property.

cluster-api/bootstrap/kubeadm/types/v1beta1/types.go

Line 67 in fd73b18

// NB: This value defaults to the Machine object spec.kubernetesVersion

cluster-api/bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigs.yaml

Line 285 in fd73b18

plane. NB: This value defaults to the Machine object spec.kubernetesVersion'

cluster-api/bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigs.yaml

Line 1091 in fd73b18

plane. NB: This value defaults to the Machine object spec.kubernetesVersion'

cluster-api/bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigtemplates.yaml

Line 306 in fd73b18

Machine object spec.kubernetesVersion'

cluster-api/bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigtemplates.yaml

Line 1144 in fd73b18

Machine object spec.kubernetesVersion'

What did you expect to happen:
I expected it to be spec.Version as described here:

cluster-api/api/v1alpha3/machine_types.go

Lines 58 to 61 in fd73b18

	// Version defines the desired Kubernetes version.
	// This field is meant to be optionally used by bootstrap providers.
	// +optional
	Version *string `json:"version,omitempty"`

/kind bug
/area api

[k8s-ci-robot]

@wfernandes: The label(s) area/ cannot be applied, because the repository doesn't have them

In response to this:

What steps did you take and what happened:
In the following files we reference spec.kubernetesVersion for the Machine object. But I don't believe we have that property.

cluster-api/bootstrap/kubeadm/types/v1beta1/types.go

Line 67 in fd73b18

// NB: This value defaults to the Machine object spec.kubernetesVersion

cluster-api/bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigs.yaml

Line 285 in fd73b18

plane. NB: This value defaults to the Machine object spec.kubernetesVersion'

cluster-api/bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigs.yaml

Line 1091 in fd73b18

plane. NB: This value defaults to the Machine object spec.kubernetesVersion'

cluster-api/bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigtemplates.yaml

Line 306 in fd73b18

Machine object spec.kubernetesVersion'

cluster-api/bootstrap/kubeadm/config/crd/bases/bootstrap.cluster.x-k8s.io_kubeadmconfigtemplates.yaml

Line 1144 in fd73b18

Machine object spec.kubernetesVersion'

What did you expect to happen:
I expected it to be spec.Version as described here:

cluster-api/api/v1alpha3/machine_types.go

Lines 58 to 61 in fd73b18

	// Version defines the desired Kubernetes version.
	// This field is meant to be optionally used by bootstrap providers.
	// +optional
	Version *string `json:"version,omitempty"`

/kind bug
/area api

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[vincepri]

/help
/milestone v0.3.x

[k8s-ci-robot]

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help
/milestone v0.3.x

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[detiber]

/kind documentation

[saimanoj01]

/assign

[saimanoj01]

/lifecycle active