Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements in Developers Guide #2956

Closed
prankul88 opened this issue Apr 24, 2020 · 5 comments · Fixed by #2972
Closed

Improvements in Developers Guide #2956

prankul88 opened this issue Apr 24, 2020 · 5 comments · Fixed by #2972
Assignees
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.

Comments

@prankul88
Copy link
Contributor

What steps did you take and what happened:
Going through the developers guide, I noticed a few things that were missing.

  1. Edit Manifests section does not tell the file where the image name needs to change. (for capd).
  2. The management cluster requires cert-manager as a pre-requisite (now handled by clusterctl), which is not mentioned in the developer guide.

What did you expect to happen:

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Cluster-api version: v0.3.3
  • Minikube/KIND version:
  • Kubernetes version: (use kubectl version):
  • OS (e.g. from /etc/os-release):

/kind documentation

@k8s-ci-robot k8s-ci-robot added the kind/documentation Categorizes issue or PR as related to documentation. label Apr 24, 2020
@fabriziopandini
Copy link
Member

/help

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Apr 24, 2020
@vincepri
Copy link
Member

/milestone Next

Happy to put it in v0.3 milestone if someone can pick this up

@k8s-ci-robot k8s-ci-robot added this to the Next milestone Apr 27, 2020
@prankul88
Copy link
Contributor Author

If no one is taking this up, I can assign it to me. Will push the patch today.

@prankul88
Copy link
Contributor Author

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/documentation Categorizes issue or PR as related to documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants