Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a temporary workaround to get KCP to detect Ready state faster #2906

Closed
fabriziopandini opened this issue Apr 14, 2020 · 4 comments · Fixed by #2907
Closed

Add a temporary workaround to get KCP to detect Ready state faster #2906

fabriziopandini opened this issue Apr 14, 2020 · 4 comments · Fixed by #2907
Assignees
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature.
Milestone

Comments

@fabriziopandini
Copy link
Member

fabriziopandini commented Apr 14, 2020

User Story

As a developer/user/operator I would like KCP to detect Ready state in a reliable way.

Detailed Description

The KCP Ready state depends by the controller to detect node state changes.

This is going to be addressed by #2880 and by follow up PRs making KCP to use the new remote cluster cache.

However, in the meantime, KCP is somehow unpredictable in detecting Ready state because it mostly depends on the resync loop. This makes bad user experience and it introduces some flakiness in the e2e test due to timeouts hard to tune.

This issue is about introducing a temporary workaround in KCP making the controller to continuously re-queue until the Ready state is reached

/kind feature

@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The label(s) area/controlplane cannot be applied, because the repository doesn't have them

In response to this:

User Story

As a developer/user/operator I would like KCP to detect Ready state in a reliable way.

Detailed Description

The KCP Ready state depends by the controller to detect node state changes.

This is going to be addressed by #2880 and by follow up PRs making KCP to use the new remote cluster cache.

However, in the meantime, KCP is somehow unpredictable in detecting Ready state because it mostly depends on the resync loop. This makes bad user experience and it introduces some flakiness in the e2e test due to timeouts hard to tune.

This issue is about introducing a temporary workaround in KCP making the controller to continuously re-queue until the Ready state is reached

/area controlplane
/kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 14, 2020
@fabriziopandini fabriziopandini changed the title Add a temporary workaround to get KCP KCP to detect Ready state faster Add a temporary workaround to get KCP to detect Ready state faster Apr 14, 2020
@k8s-ci-robot
Copy link
Contributor

@fabriziopandini: The label(s) area/controlplane cannot be applied, because the repository doesn't have them

In response to this:

User Story

As a developer/user/operator I would like KCP to detect Ready state in a reliable way.

Detailed Description

The KCP Ready state depends by the controller to detect node state changes.

This is going to be addressed by #2880 and by follow up PRs making KCP to use the new remote cluster cache.

However, in the meantime, KCP is somehow unpredictable in detecting Ready state because it mostly depends on the resync loop. This makes bad user experience and it introduces some flakiness in the e2e test due to timeouts hard to tune.

This issue is about introducing a temporary workaround in KCP making the controller to continuously re-queue until the Ready state is reached

/area controlplane
/kind feature

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@vincepri
Copy link
Member

/area control-plane
/milestone v0.3.4

I'd like to get this in v0.3.4, and replace it by #2880 and any follow-up PRs when it's ready.

@k8s-ci-robot k8s-ci-robot added this to the v0.3.4 milestone Apr 14, 2020
@k8s-ci-robot k8s-ci-robot added the area/control-plane Issues or PRs related to control-plane lifecycle management label Apr 14, 2020
@benmoss
Copy link

benmoss commented Apr 14, 2020

/assign @fabriziopandini
#2907

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Issues or PRs related to control-plane lifecycle management kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants