Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clustertctl should validate kubernetes version is >= v1.16.0 #2837

Closed
fabriziopandini opened this issue Apr 1, 2020 · 4 comments · Fixed by #2842
Closed

Clustertctl should validate kubernetes version is >= v1.16.0 #2837

fabriziopandini opened this issue Apr 1, 2020 · 4 comments · Fixed by #2842
Assignees
Labels
area/clusterctl Issues or PRs related to clusterctl help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone

Comments

@fabriziopandini
Copy link
Member

What steps did you take and what happened:
xref kubernetes-sigs/cluster-api-provider-aws#1676

Clustertctl fails if the management cluster is <= v1.16.0

Followed the Quickstart in the docs line by line exactly and I got this error when running:
clusterctl init --infrastructure aws

Error: action failed after 10 attempts: failed to create clusterctl inventory CRDs component: apiextensions.k8s.io/v1, Kind=CustomResourceDefinition, /providers.clusterctl.cluster.x-k8s.io: n
o matches for kind "CustomResourceDefinition" in version "apiextensions.k8s.io/v1

What did you expect to happen:
Clustertctl should validate that the management cluster is >= v1.16.0 or provide a meaningful error message to the users

Anything else you would like to add:
As a first thought, this check can be implemented as a part of the "EnsureCustomResourceDefinitions", which is the first method called in most of the clusterctl commands and the first requiring v1.16.0 features

Environment:

Cluster-api-provider-aws version:

clusterctl version: &version.Info{Major:"0", Minor:"3", GitVersion:"v0.3.3", GitCommit:"ecff70af1b839c4086335234d88b1b8c00c3383c", GitTreeState:"clean", BuildDate:"2020-03-27T22:25:55Z", GoVe
rsion:"go1.13.8", Compiler:"gc", Platform:"darwin/amd64"}

Kubernetes version: (use kubectl version):

Client Version: version.Info{Major:"1", Minor:"16", GitVersion:"v1.16.4", GitCommit:"224be7bdce5a9dd0c2fd0d46b83865648e2fe0ba", GitTreeState:"clean", BuildDate:"2019-12-11T12:47:40Z", GoVersi
on:"go1.12.12", Compiler:"gc", Platform:"darwin/amd64"}
Server Version: version.Info{Major:"1", Minor:"15+", GitVersion:"v1.15.10-eks-bac369", GitCommit:"bac3690554985327ae4d13e42169e8b1c2f37226", GitTreeState:"clean", BuildDate:"2020-02-26T01:12:
54Z", GoVersion:"go1.12.12", Compiler:"gc", Platform:"linux/amd64"}

OS (e.g. from /etc/os-release):

MacOS Catalina 10.15.4

/kind bug
/area clusterctl

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. area/clusterctl Issues or PRs related to clusterctl labels Apr 1, 2020
@vincepri
Copy link
Member

vincepri commented Apr 1, 2020

/milestone v0.3.4
/help
/priority important-soon

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/milestone v0.3.4
/help
/priority important-soon

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added this to the v0.3.4 milestone Apr 1, 2020
@k8s-ci-robot k8s-ci-robot added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 1, 2020
@prksu
Copy link
Contributor

prksu commented Apr 1, 2020

i'll take this one
/assign

@fabriziopandini
Copy link
Member Author

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/clusterctl Issues or PRs related to clusterctl help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/bug Categorizes issue or PR as related to a bug. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants