Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log which value clusterctl mover is setting when pausing #2677

Closed
vincepri opened this issue Mar 13, 2020 · 2 comments · Fixed by #2687
Closed

Log which value clusterctl mover is setting when pausing #2677

vincepri opened this issue Mar 13, 2020 · 2 comments · Fixed by #2687
Assignees
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Milestone

Comments

@vincepri
Copy link
Member

At https://github.com/kubernetes-sigs/cluster-api/blob/master/cmd/clusterctl/client/cluster/mover.go#L289, the setClusterPause function takes a value that could be either true or false. We should log the value out to be more explicit and communicate to users what are we actually setting.

/milestone v0.3.x
/help
/good-first-issue

@k8s-ci-robot k8s-ci-robot added this to the v0.3.x milestone Mar 13, 2020
@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as suitable for new contributors.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-good-first-issue command.

In response to this:

At https://github.com/kubernetes-sigs/cluster-api/blob/master/cmd/clusterctl/client/cluster/mover.go#L289, the setClusterPause function takes a value that could be either true or false. We should log the value out to be more explicit and communicate to users what are we actually setting.

/milestone v0.3.x
/help
/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Mar 13, 2020
@vincepri vincepri changed the title Log which value clusterctl mover is setting Log which value clusterctl mover is setting when pausing Mar 13, 2020
@SataQiu
Copy link
Member

SataQiu commented Mar 16, 2020

/assign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants