Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util package: Make functions that fetch/filter many Machines consistent with one another #2062

Closed
dlipovetsky opened this issue Jan 14, 2020 · 18 comments · Fixed by #4207
Closed

util package: Make functions that fetch/filter many Machines consistent with one another #2062

dlipovetsky opened this issue Jan 14, 2020 · 18 comments · Fixed by #4207
Assignees
@CecileRobertMichon
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Milestone
v0.4

Comments

@dlipovetsky
Copy link
Contributor

The util package has functions that fetch or filter many machines. Some functions use the clusterv1.MachineList type, others use []*clusterv1.Machine. Let's standardize on one.

(Issue came out this discussion: #2037 (comment))

/priority important/long-term
@k8s-ci-robot
Copy link
Contributor

@dlipovetsky: The label(s) priority/important/long-term cannot be applied, because the repository doesn't have them

In response to this:

The util package has functions that fetch or filter many machines. Some functions use the clusterv1.MachineList type, others use []*clusterv1.Machine. Let's standardize on one.

(Issue came out this discussion: #2037 (comment))

/priority important/long-term

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dlipovetsky dlipovetsky changed the title Make functions in util package consistent with one another util package: Make functions that fetch/filter many Machines consistent with one another Jan 14, 2020
@k8s-ci-robot
Copy link
Contributor

@dlipovetsky: The label(s) priority/important/long-term cannot be applied, because the repository doesn't have them

In response to this:

The util package has functions that fetch or filter many machines. Some functions use the clusterv1.MachineList type, others use []*clusterv1.Machine. Let's standardize on one.

(Issue came out this discussion: #2037 (comment))

/priority important/long-term

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dlipovetsky dlipovetsky mentioned this issue Jan 14, 2020
Merged
@dlipovetsky
Copy link
Contributor Author

dlipovetsky commented Jan 14, 2020 •
edited
Loading

the slice of pointers has the benefit of avoid unnecessary copies when passing the items around.

-- #2037 (comment)

@vincepri
Copy link
Member

/help

@k8s-ci-robot
Copy link
Contributor

@vincepri:
This request has been marked as needing help from a contributor.

Please ensure the request meets the requirements listed here.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 15, 2020
@ncdc ncdc added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Jan 15, 2020
@ncdc ncdc added this to the Next milestone Jan 15, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Apr 14, 2020
@detiber
Copy link
Member

detiber commented Apr 14, 2020

/lifecycle frozen

@k8s-ci-robot k8s-ci-robot added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Apr 14, 2020
@vincepri vincepri removed the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Apr 20, 2020
@vincepri
Copy link
Member

/priority backlog

@k8s-ci-robot k8s-ci-robot added the priority/backlog Higher priority than priority/awaiting-more-evidence. label Apr 20, 2020
@vincepri vincepri removed the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Apr 20, 2020
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 19, 2020
@vincepri
Copy link
Member

/lifecycle frozen
/milestone v0.4.0

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 20, 2020
@k8s-ci-robot k8s-ci-robot modified the milestones: Next, v0.4.0 Jul 20, 2020
@k8s-ci-robot k8s-ci-robot added the lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. label Jul 20, 2020
@pydctw
Copy link

pydctw commented Jan 13, 2021

/assign

@vincepri
Copy link
Member

vincepri commented Feb 8, 2021

@pydctw Are you going to work on this issue?

@vincepri
Copy link
Member

vincepri commented Feb 8, 2021

/priority important-longterm
/help

@k8s-ci-robot k8s-ci-robot added the priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. label Feb 8, 2021
@pydctw
Copy link

pydctw commented Feb 10, 2021

@pydctw Are you going to work on this issue?
thanks for the reminder. Sorry but I didn't have a chance to work on it. I will unassign for now

@pydctw
Copy link

pydctw commented Feb 10, 2021

/unassign

@fabriziopandini
Copy link
Member

@CecileRobertMichon, does #4160 fixes this problem?

@CecileRobertMichon
Copy link
Contributor

It doesn't. I can take that one separately though since I'm already in that area.

/assign

This was referenced Feb 12, 2021
Merged
Merged
@fabriziopandini
Copy link
Member

/lifecycle active
/kind cleanup

@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. and removed lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. labels Mar 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@CecileRobertMichon CecileRobertMichon

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/backlog Higher priority than priority/awaiting-more-evidence. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete.
Projects
None yet
Milestone
v0.4
9 participants
@ncdc @detiber @vincepri @dlipovetsky @fabriziopandini @CecileRobertMichon @k8s-ci-robot @pydctw @fejta-bot