Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create integration test for machine controller. #11

Closed
rsdcastro opened this issue Apr 12, 2018 · 17 comments
Closed

create integration test for machine controller. #11

rsdcastro opened this issue Apr 12, 2018 · 17 comments
Assignees
@figo
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v1alpha1

Comments

@rsdcastro
Copy link

From @medinatiger on January 8, 2018 19:46

We need to have integration test to test machine controller. The following scenario is interested.

  1. Basic create/update/delete through API
  2. Scale up
  3. Scale down
  4. Stress test with combination of ScaleUp/ScaleDown
  5. Upgrade.
  6. Mixed upgrade and scale operation simultaneously

Copied from original issue: kubernetes-retired/kube-deploy#476
@rsdcastro rsdcastro added cluster-api help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. labels Apr 12, 2018
@rsdcastro
Copy link
Author

From @k-turowski on January 17, 2018 15:55

I can take this.

@rsdcastro
Copy link
Author

This is currently unassigned.

@rsdcastro rsdcastro mentioned this issue Apr 12, 2018
Closed
@rsdcastro rsdcastro added this to the cluster-api-alpha-implementation milestone Apr 13, 2018
@rsdcastro
Copy link
Author

/assign @spew

@spew
Copy link
Contributor

spew commented May 30, 2018

Think #4 and #6 are out of scope for alpha. Those require significantly more effort and probably are not as critical as basic functionality at this point.

@enxebre
Copy link
Member

enxebre commented Jul 23, 2018

is this to be tested with all real actuator implementations? or would it be using say a fake actuator stub?

@roberthbailey
Copy link
Contributor

@enxebre - we should have a conformance-style test that each provider can run to verify that they work "correctly". It may be worthwhile to create an actuator stub in this repository so that we can put the test code here (and run it) once all of the provider code has been migrated out.

@roberthbailey
Copy link
Contributor

/unassign

roberthbailey pushed a commit to roberthbailey/cluster-api that referenced this issue Sep 27, 2018
Merge pull request kubernetes-sigs#11 from roberthbailey/clusterctl-crds
7804a83 
Minor fixes to make clusterctl work with CRDs.
@roberthbailey roberthbailey added good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. kind/cluster-api labels Jan 10, 2019
@timothysc timothysc modified the milestones: cluster-api-alpha-implementation, v1alpha1 Jan 10, 2019
@timothysc timothysc added priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. and removed kind/cluster-api labels Jan 10, 2019
@figo
Copy link
Contributor

figo commented Feb 13, 2019

looks like no one is working on this, plan to take on this issue and assign to myself, let me know if any objection.

@vincepri
Copy link
Member

@figo Go for it! You can mark the issue with /lifecycle active to mark it as taken.

@pablochacin
Copy link
Contributor

@figo I was about to pick it! 🏃‍♂️ 😄
Please let me know if you want some help from me.

@vincepri vincepri mentioned this issue Feb 13, 2019
Closed
@figo
Copy link
Contributor

figo commented Feb 13, 2019

@pablochacin i have a WIP PR to create a simple mock up provider and integration with Prow. i definitely welcome cooperations.

@figo
Copy link
Contributor

figo commented Feb 13, 2019

/lifecycle active

@k8s-ci-robot k8s-ci-robot added the lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. label Feb 13, 2019
@pablochacin
Copy link
Contributor

@figo I kind reminder to share with me the repository fork on which you are working you PR.

@figo
Copy link
Contributor

figo commented Feb 14, 2019

@pablochacin will share with you soon, thank you

@figo
Copy link
Contributor

figo commented Feb 14, 2019

@pablochacin let me know if you want to have some discussion around this, here is the branch: https://github.com/figo/cluster-api/tree/integration

@figo figo mentioned this issue Feb 14, 2019
Merged
@pablochacin
Copy link
Contributor

@figo I just saw your PR. I'll comment there. Thanks

@figo
Copy link
Contributor

figo commented Feb 27, 2019

/assign

@pablochacin pablochacin mentioned this issue Mar 2, 2019
Merged
4 tasks
chuckha pushed a commit to chuckha/cluster-api that referenced this issue Oct 2, 2019
@k8s-ci-robot
Merge pull request kubernetes-sigs#11 from neolit123/update-readme
8639b13 
README: modify the build step for binaries
@enxebre enxebre mentioned this issue Feb 5, 2020
Closed
6 tasks
anusha94 pushed a commit to anusha94/cluster-api that referenced this issue Jun 29, 2021
@fabriziopandini
Merge pull request kubernetes-sigs#11 from fabriziopandini/activate-m…
fd9702b 
…ore-linters

Activate more linters
killianmuldoon referenced this issue in killianmuldoon/cluster-api Mar 30, 2022
@fabriziopandini
Implement Registry (#11)
9999008
ahreehong pushed a commit to ahreehong/cluster-api that referenced this issue Feb 7, 2023
@abhinavmpandey08
Merge pull request kubernetes-sigs#11 from abhinavmpandey08/br-ntp-patch
bf72ccb 
✨ Add support for configuring NTP servers on bottlerocket through CAPI
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@figo figo

Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. lifecycle/active Indicates that an issue or PR is actively being worked on by a contributor. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v1alpha1
Development

No branches or pull requests
9 participants
@figo @timothysc @rsdcastro @pablochacin @enxebre @spew @vincepri @roberthbailey @k8s-ci-robot