Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance the RequeueError to support wrapping/interfaces #1018

Closed
akutz opened this issue Jun 12, 2019 · 1 comment · Fixed by #1020
Closed

Enhance the RequeueError to support wrapping/interfaces #1018

akutz opened this issue Jun 12, 2019 · 1 comment · Fixed by #1020
Labels
area/api Issues or PRs related to the APIs kind/feature Categorizes issue or PR as related to a new feature.

Comments

@akutz
Copy link
Contributor

akutz commented Jun 12, 2019

/kind feature

Describe the solution you'd like
Today the RequeueAfterError is subject to being lost due to wrapping, and does not support additional data since RequeueAfterError is a struct, not an interface. I would like to see support for:

  • Wrapped RequeueAfterError errors
  • An interface for RequeueAfterError

Anything else you would like to add:
Nope
@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Jun 12, 2019
akutz added a commit to akutz/cluster-api that referenced this issue Jun 12, 2019
@akutz
Support for wrapped RequeueAfterError/interface
c22bd47 
This patch fixes kubernetes-sigs#1018 and supports wrapped "RequeueAfterError" errors
as well as a new interface for supporting custom "RequeueAfterError"
errors.
@vincepri
Copy link
Member

/area api
/priority important-backlog

@k8s-ci-robot k8s-ci-robot added the area/api Issues or PRs related to the APIs label Jun 12, 2019
@akutz akutz mentioned this issue Jun 12, 2019
Merged
akutz added a commit to akutz/cluster-api that referenced this issue Jun 12, 2019
@akutz
Support for wrapped RequeueAfterError/interface
a8d128d 
This patch fixes kubernetes-sigs#1018 and supports wrapped "RequeueAfterError" errors
as well as a new interface for supporting custom "RequeueAfterError"
errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/api Issues or PRs related to the APIs kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support for wrapped RequeueAfterError/interface akutz/cluster-api
3 participants
@akutz @vincepri @k8s-ci-robot