Follow-up Tasks for MachinePool support in ClusterClass

[willie-yao]

What would you like to be added (User Story)?

This is a follow up to #5991 to track the remaining follow-up tasks for adding MachinePool support in ClusterClass.

Detailed Description

Unit Tests

Preview Give feedback

1. internal/controllers/topology/cluster/scope/state_test.go 🌱 Add unit tests for MachinePools in topology/scope package #10052 @willie-yao
2. internal/controllers/topology/cluster/scope/upgradetracker_test.go 🌱 Add unit tests for MachinePools in topology/scope package #10052 @willie-yao
3. internal/topology/check/compatibility_test.go 🌱 Add unit tests for MachinePools in topology/scope package #10052 @willie-yao
4. internal/webhooks/cluster_test.go 🌱 Add unit tests for MachinePools for webhooks and cc controller #10055 @willie-yao
5. internal/webhooks/clusterclass_test.go 🌱 Add unit tests for MachinePools for webhooks and cc controller #10055 @willie-yao
6. internal/webhooks/patch_validation_test.go 🌱 Add unit tests for MachinePools for webhooks and cc controller #10055 @willie-yao
7. internal/controllers/clusterclass/clusterclass_controller_test.go 🌱 Add unit tests for MachinePools for webhooks and cc controller #10055 @willie-yao
8. test/extension/handlers/topologymutation/handler_test.go 🌱 Add MachinePools to handler and topology test #10216 @willie-yao
9. cmd/clusterctl/client/cluster/topology_test.go 🌱 Add MachinePools to handler and topology test #10216 @willie-yao
10. Run unit & integration tests with coverage and check if we missed something

E2E Tests

Preview Give feedback

1. ClusterClass changes & rollout (clusterclass_changes.go & clusterclass_rollout, flavor: "topology") 🌱 Add MachinePools to Runtime SDK and Rollout tests #9703
2. clusterctl upgrade (clusterctl_upgrade.go, workload flavor: "topology") 🐛 test/e2e: Calculate correct worker count in clusterctl upgrade test #9892
3. Runtime SDK (cluster_upgrade_runtimesdk.go, flavor: "upgrades-runtimesdk") 🌱 Add MachinePools to Runtime SDK and Rollout tests #9703
4. Self-hosted (self_hosted.go, flavor: "topology") 🌱 Add WaitForMachinePoolToBeUpgraded to self-hosted test  #9540
5. Autoscaler (autoscaler.go, flavor: "topology-autoscaler") 🌱 Add MachinePools to autoscaler e2e test #10083
6. Audit if there are any Cluster YAMLs left in the test folder which don't have a machinePool in Cluster.spec.topology

Misc/Documentation

Preview Give feedback

1. Update proposal 📖 Add MachinePools to ClusterClass Documentation #10418
2. Update docs (probably mostly book) 📖 Add MachinePools to ClusterClass Documentation #10418

Non-blocking for MP Graduation

Preview Give feedback

1. Dualstack e2e tests 🌱 Add MP back to dualstack E2E test #10135
2. TBD: internal/controllers/topology/machinepool might be not needed as MachinePool.reconcileDelete deletes templates

Later

• TBD: consider de-duplicating MD/MP code
• TBD: MachinePool upgrading use Node list instead of Node get
• MHC for MachinePools: depends on MachinePool Machines

Anything else you would like to add?

No response

Label(s) to be applied

/kind feature

[willie-yao]

/assign

[willie-yao]

/area clusterclass

[sbueringer]

/triage accepted

Would be really nice to get the test coverage for MachinePools

[willie-yao]

Would be really nice to get the test coverage for MachinePools

Apologies for the delay, it's next on my list!

[sbueringer]

No worries :) Thank you very much!

[willie-yao]

Update: We decided in office hours that we should fix the flakes in the dualstack test for MachineDeployments before implementing them for MachinePools. Therefore, the dualstack test for MachinePools will be non-blocking for MachinePool graduation.

[fabriziopandini]

/priority backlog

[willie-yao]

Run unit & integration tests with coverage and check if we missed something

Verified that all instances of MP support in existing files related to ClusterClass have test coverage.

[willie-yao]

Audit if there are any Cluster YAMLs left in the test folder which don't have a machinePool in Cluster.spec.topology

Verified all templates inside test/e2e/data/infrastructure-docker/main besides the dualstack specs include MachinePools in the topology.

[willie-yao]

@sbueringer Are we good to close this issue? All defined tasks have been completed!

[sbueringer]

Looks good. Thank you very much again!
/close

[k8s-ci-robot]

@sbueringer: Closing this issue.

In response to this:

Looks good. Thank you very much again!
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.