Merge pull request #8035 from ykakarap/clusterct-rollback-valid-resou…

…rces 🌱 remove KCP as a valid resource type for rollback
kubernetes-sigs · Feb 1, 2023 · eb808f2 · eb808f2
2 parents aa5eacf + 1e2d604
commit eb808f2
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/cmd/clusterctl/client/alpha/rollout.go b/cmd/clusterctl/client/alpha/rollout.go
@@ -34,6 +34,10 @@ var validResourceTypes = []string{
 	KubeadmControlPlane,
 }
 
+var validRollbackResourceTypes = []string{
+	MachineDeployment,
+}
+
 // Rollout defines the behavior of a rollout implementation.
 type Rollout interface {
 	ObjectRestarter(cluster.Proxy, corev1.ObjectReference) error

diff --git a/cmd/clusterctl/client/alpha/rollout_rollbacker.go b/cmd/clusterctl/client/alpha/rollout_rollbacker.go
@@ -41,7 +41,7 @@ func (r *rollout) ObjectRollbacker(proxy cluster.Proxy, ref corev1.ObjectReferen
 			return err
 		}
 	default:
-		return errors.Errorf("invalid resource type %q, valid values are %v", ref.Kind, validResourceTypes)
+		return errors.Errorf("invalid resource type %q, valid values are %v", ref.Kind, validRollbackResourceTypes)
 	}
 	return nil
 }