Skip to content

Commit

Permalink
fix of sed (#754)
Browse files Browse the repository at this point in the history
there is no sed in-place flag that works for both linux and OSX.
the workaround is to produce a .tmp file, then developer will notice
this is the file does not need be checked in.
  • Loading branch information
figo authored and k8s-ci-robot committed Feb 14, 2019
1 parent 256aac9 commit e621840
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 12 deletions.
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ clean: ## Remove all generated files
docker-build: generate fmt vet manifests ## Build the docker image
docker build . -t ${IMG}
@echo "updating kustomize image patch file for manager resource"
sed -i'' -e 's@image: .*@image: '"${IMG}"'@' ./config/default/manager_image_patch.yaml
sed -i.tmp -e 's@image: .*@image: '"${IMG}"'@' ./config/default/manager_image_patch.yaml

.PHONY: docker-push
docker-push: ## Push the docker image
Expand Down
11 changes: 0 additions & 11 deletions config/default/manager_image_patch.yaml-e

This file was deleted.

0 comments on commit e621840

Please sign in to comment.