Skip to content

Commit

Permalink
Remove NodeConditions from Machine.Status
Browse files Browse the repository at this point in the history
Signed-off-by: Vince Prignano <[email protected]>
  • Loading branch information
vincepri committed Jul 11, 2019
1 parent 09e491e commit dee2b39
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 51 deletions.
36 changes: 0 additions & 36 deletions config/crds/cluster.sigs.k8s.io_machines.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -646,42 +646,6 @@ spec:
bootstrapReady:
description: BootstrapReady is the state of the bootstrap provider.
type: boolean
conditions:
description: 'Conditions lists the conditions synced from the node conditions
of the corresponding node-object. Machine-controller is responsible
for keeping conditions up-to-date. MachineSet controller will be taking
these conditions as a signal to decide if machine is healthy or needs
to be replaced. Refer: https://kubernetes.io/docs/concepts/architecture/nodes/#condition'
items:
description: NodeCondition contains condition information for a node.
properties:
lastHeartbeatTime:
description: Last time we got an update on a given condition.
format: date-time
type: string
lastTransitionTime:
description: Last time the condition transit from one status to
another.
format: date-time
type: string
message:
description: Human readable message indicating details about last
transition.
type: string
reason:
description: (brief) reason for the condition's last transition.
type: string
status:
description: Status of the condition, one of True, False, Unknown.
type: string
type:
description: Type of node condition.
type: string
required:
- status
- type
type: object
type: array
errorMessage:
description: "ErrorMessage will be set in the event that there is a
terminal problem reconciling the Machine and will contain a more verbose
Expand Down
8 changes: 0 additions & 8 deletions pkg/apis/cluster/v1alpha2/machine_types.go
Original file line number Diff line number Diff line change
Expand Up @@ -150,14 +150,6 @@ type MachineStatus struct {
// +optional
Addresses []corev1.NodeAddress `json:"addresses,omitempty"`

// Conditions lists the conditions synced from the node conditions of the corresponding node-object.
// Machine-controller is responsible for keeping conditions up-to-date.
// MachineSet controller will be taking these conditions as a signal to decide if
// machine is healthy or needs to be replaced.
// Refer: https://kubernetes.io/docs/concepts/architecture/nodes/#condition
// +optional
Conditions []corev1.NodeCondition `json:"conditions,omitempty"`

// Phase represents the current phase of machine actuation.
// E.g. Pending, Running, Terminating, Failed etc.
// +optional
Expand Down
7 changes: 0 additions & 7 deletions pkg/apis/cluster/v1alpha2/zz_generated.deepcopy.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit dee2b39

Please sign in to comment.