Skip to content

Commit

Permalink
Merge pull request #9401 from k8s-infra-cherrypick-robot/cherry-pick-…
Browse files Browse the repository at this point in the history
…9400-to-release-1.5

[release-1.5] 🌱 Improve message for TopologyReconciledCondition
  • Loading branch information
k8s-ci-robot authored Sep 12, 2023
2 parents bf8e700 + c5908c6 commit cc26af1
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 5 deletions.
3 changes: 2 additions & 1 deletion internal/controllers/topology/cluster/conditions.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,8 @@ func (r *Reconciler) reconcileTopologyReconciledCondition(s *scope.Scope, cluste
clusterv1.TopologyReconciledCondition,
clusterv1.TopologyReconciledClusterClassNotReconciledReason,
clusterv1.ConditionSeverityInfo,
"ClusterClass not reconciled. If this condition persists please check ClusterClass status.",
"ClusterClass not reconciled. If this condition persists please check ClusterClass status. A ClusterClass is reconciled if"+
".status.observedGeneration == .metadata.generation is true. If this is not the case either ClusterClass reconciliation failed or the ClusterClass is paused",
),
)
return nil
Expand Down
9 changes: 5 additions & 4 deletions internal/controllers/topology/cluster/conditions_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,11 @@ func TestReconcileTopologyReconciledCondition(t *testing.T) {
},
},
},
wantConditionStatus: corev1.ConditionFalse,
wantConditionReason: clusterv1.TopologyReconciledClusterClassNotReconciledReason,
wantConditionMessage: "ClusterClass not reconciled. If this condition persists please check ClusterClass status.",
wantErr: false,
wantConditionStatus: corev1.ConditionFalse,
wantConditionReason: clusterv1.TopologyReconciledClusterClassNotReconciledReason,
wantConditionMessage: "ClusterClass not reconciled. If this condition persists please check ClusterClass status. A ClusterClass is reconciled if" +
".status.observedGeneration == .metadata.generation is true. If this is not the case either ClusterClass reconciliation failed or the ClusterClass is paused",
wantErr: false,
},
{
name: "should set the condition to false if the there is a blocking hook",
Expand Down

0 comments on commit cc26af1

Please sign in to comment.